uefi: Fix wrong install_configuration_table() signature #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Lgtm, thanks for the fix. I put up #844 with the lint/align fixes cherry-picked in, as well as one more ci fix, so we can get the CI green again.
Interestingly, this crashes on aarch64 but works on x86_64. Likely, the x86_64 calling convention used still passes the Guid struct by pointer, while the aarch64 passes it by value (or in an unexpected registers) causing a crash. This also adds a test case to verify this works correctly now. Fixes: #842
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interestingly, this crashes on aarch64 but works on x86_64. Likely,
the x86_64 calling convention used still passes the Guid struct by
pointer, while the aarch64 passes it by value (or in an unexpected
registers) causing a crash.
This also adds a test case to verify this works correctly now.
Fixes: #842